Conversation
️✔️AzureCLI-FullTest
|
|
Hi @khkh-ms, |
️✔️AzureCLI-BreakingChangeTest
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Pull Request Overview
This PR enables Elastic Premium SKUs (EP1, EP2, EP3) to support zone redundancy in Azure Function App plans. Previously, zone redundancy was only available for Premium V2/V3/V4 and Isolated V2 SKUs.
Key changes:
- Added 'ELASTICPREMIUM' to the list of supported SKUs for zone redundancy
- Added three test cases to verify zone redundancy works with EP1, EP2, and EP3 SKUs
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| _validators.py | Updated supported SKU list to include ELASTICPREMIUM for zone redundancy validation |
| test_functionapp_commands.py | Added three new test methods for EP1, EP2, and EP3 zone redundancy scenarios |
| test_functionapp_create_elastic_premium_zone_redundant_plan.yaml | Test recording for EP1 zone redundancy test |
| test_functionapp_create_elastic_premium_ep2_zone_redundant_plan.yaml | Test recording for EP2 zone redundancy test |
| test_functionapp_create_elastic_premium_ep3_zone_redundant_plan.yaml | Test recording for EP3 zone redundancy test |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| code: 200 | ||
| message: OK | ||
| - request: | ||
| body: '{"location": "francecentral", "sku": {"name": "EP1", "tier": "ElasticPremium", |
There was a problem hiding this comment.
The test recording for EP2 is using 'EP1' as the SKU name instead of 'EP2'. This indicates the test recording does not match the test method name and may not properly validate EP2 zone redundancy support.
| body: '{"location": "francecentral", "sku": {"name": "EP1", "tier": "ElasticPremium", | |
| body: '{"location": "francecentral", "sku": {"name": "EP2", "tier": "ElasticPremium", |
az functionapp plan create: Add Elastic Premium as supported SKU for Zone Redundencyaz functionapp plan create: Add Elastic Premium as supported SKU for Zone Redundency
az functionapp plan create: Add Elastic Premium as supported SKU for Zone Redundencyaz functionapp plan create: Add elastic premium as supported SKU for zone redundency
Related command
az functionapp plan create --name {name} --resource-group {resrouce-group} --location {region} --sku EP1 --zone-redundant --min-instances 3
Description
Add Elastic Premium as supported SKU for Zone Redundency
Testing Guide
Added the test coverage
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.